Repository navigation
feat!: namespace-qualify application identities - #220
Merged
Merged
Conversation
#219) With --workspace-root, symbol_table keys, module ids and every id below them, and artifact keys/paths/ids are relative to the workspace root instead of --input, matching codeanalyzer-java. The re-key happens at emission only: signatures, entrypoint path rules, test-file detection and the cache keep the input-relative key. --input outside the root is an InputError.
|
@georgesafta , again checking the existing neo4j database case. For typescript, we do have the "--eager" to purge - perhaps should document it and require to use it in case there is data already in neo4j. |
georgesafta
marked this pull request as ready for review
October 29, 2026 18:48
This was referenced Oct 30, 2026
This was referenced Oct 31, 2026
Merged
rahlk
changed the title
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Namespace/application ownership now produces
can://<namespace>/<application>/…roots, including the repeated default monolith root. Raw inputs are validated and UTF-8 encoded consistently; integeridentity_version: 2and raw owner metadata reject incompatible persisted outputs. Existing suffixes and application-relative keys are retained.The namespace option replaces the unmerged workspace-root option. Embedded references, graph scopes, cache compatibility and selected-root reconciliation follow the canonical owner while retaining unrelated existing branch fixes. Legacy output must be regenerated from source.
Closes #221.
Coordinated tracking: python-sdk #435, codeanalyzer-python #236, codeanalyzer-java #276, codeanalyzer-go #40.
Existing producer PRs: Python #235, TS/JS #220, Java #275. Companion PRs: Go #41, SDK #440 (Draft).
Validation: Full suite: 399 passed, 23 skipped; CLI empty-name follow-up: 71 passed; typecheck passed. Cross-repository native L2 smoke: 20 cases / 60 canonical endpoint references; explicit sibling services, defaults and raw punctuation/Unicode passed. Shared six-copy golden fixture hash matches; diff checks clean.
The initial isolated checks lacked Docker/live Neo4j; actual follow-up live validation is recorded below. Downstream canonical-index/finding-join adoption remains separately required; no private integration fix is claimed.
Online Boutique live validation (2026-10-31)
Cloned Online Boutique at c7cb6d5 over SSH and projected all 11 supported services into one Neo4j Community 5.26.0 database. C# cartservice was skipped. All SDK verification used Neo4j backends, with no SDK JSON/local fallback.
The live run exposed three defects, now fixed and reviewed in TS/JS #220 (
6d80997: relative graph module keys and class ownership during eager reconciliation) and SDK #440 (928ce57: retain Python module/class/callable IDs during graph reconstruction). All regressions were observed RED before the fixes.Verification after fixes: TS/JS namespace/Neo4j suites 70 passed,23 skipped; typecheck/build passed. SDK focused88 passed; full available SDK1952 passed,422 skipped,85.34%coverage. Java and all four Go services passed strict full-depth live projection after build/toolchain setup (JDK21/Gradle8.14.5; Go1.26.10 with GOTOOLCHAIN=local). Existing skipped suites are not claimed as passing.
The release dependency gate is complete; current published-package verification is recorded below. Private integration ingestion/joins remain external. A fresh currency-only TS/JS graph still hits the existing required-relationship fingerprint; the completed multi-service database passes. Currency module-scope results include an existing source-hydration diagnostic, while ownership/position assertions pass. No microservice business RPC deployment, merge or release was performed.
Coordinated releases published
Python1.7.0, TypeScript1.7.0, Java3.4.0, Go0.3.0, and SDK2.1.0. All five task PRs are merged. SDK pins and uv.lock use these producer releases.
Fresh Python3.11 validation with the real published producers:1960SDKtests passed,414skipped,85.48%coverage. All11 supported OnlineBoutique services were reprojected into one Neo4j database using the published analyzer wheels; the installed SDK wheel passed service/namespace isolation, canonical-ID equality/deduplication, original source-position regression and read-only checks. SDK was then reinstalled directly from PyPI and passed the same live checks.
Downstream consumer integration adoption and the documented sparse-graph/source-hydration limitations remain separate from this completed release gate.